Then, do we let it all through?

pass inet proto icmp 

Pro: makes debugging easier

Con: may reveal too much about your network

Note: some ICMP traffic piggybacks on keep state